Design comparison
SolutionDesign
Solution retrospective
What else can I improve on?
Community feedback
- @elaineleungPosted over 2 years ago
Hi Luis-Olivero, well done in completing your second challenge! I see that this is your second attempt, so it's great that you took what you learned last time and tried again. You did a lot of things well here, such as your use of
max-width
on the container and alsoobject-fit
for the object.One suggestion I have is, instead of using
padding-top: 10em
to center the component (I assume that's why you had it there), try using eitherdisplay: grid
ordisplay: flex
on the body selector, like this:body { display: flex; flex-direction: column; justify-content: center; min-height: 100vh; } or body { display: flex; place-content: center; min-height: 100vh; }
Keep going, you're doing great 🙂
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord