Product preview card component

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Luis-Olivero, well done in completing your second challenge! I see that this is your second attempt, so it's great that you took what you learned last time and tried again. You did a lot of things well here, such as your use of max-width on the container and also object-fit for the object.

  One suggestion I have is, instead of using padding-top: 10em to center the component (I assume that's why you had it there), try using either display: grid or display: flex on the body selector, like this:

  body {
     display: flex;
     flex-direction: column;
     justify-content: center;
     min-height: 100vh;
  }
  
  or 
  
  body {
     display: flex;
     place-content: center;
     min-height: 100vh;
  }
  

  Keep going, you're doing great 🙂

  Marked as helpful

  0