Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

Sang Leโ€ข 520

@sqle157

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi,

This is my solution to this challenge. Since I haven't coded in a while, any feedbacks are welcome!

Happy coding!

Community feedback

@MelvinAguilar

Posted

Hi @sqle157 ๐Ÿ‘‹, good job on completing this challenge! ๐ŸŽ‰

Here are some suggestions you might consider:

  • In this solution, you should not use the background property to set the image because this image has an important semantic meaning, use the CSS background property if the image is not part of the content.

You can use the <picture> tag when you need to change the image on different viewports, using this tag will prevent the browser from loading both images, saving bandwidth. More information here

Example:

<picture>
   <source media="(max-width: 35em)" srcset="../images/image-product-mobile.jpg">
   <img src="../images/image-product-desktop.jpg" alt="your_alt_text">
</picture>
  • You could use the <del> tag to display the old price:
<del class="price-old">
   <span class="sr-only">Old price: </span>$169.99
</del>

Note that I added the <span> with the sr-only class to the del element, this will provide more information about what your old price is about.

The sr-only class is a class that you can add to hide content visually but is only visible to screen-readers:

More information here.

I hope those tips will help you.

Good Job and happy coding !

Marked as helpful

1

Sang Leโ€ข 520

@sqle157

Posted

@MelvinAguilar Thank you for your feedback! I will consider them into my code for future challenges.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord