Product preview card component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @sqle157 👋, good job on completing this challenge! 🎉

  Here are some suggestions you might consider:

  • In this solution, you should not use the background property to set the image because this image has an important semantic meaning, use the CSS background property if the image is not part of the content.

  You can use the <picture> tag when you need to change the image on different viewports, using this tag will prevent the browser from loading both images, saving bandwidth. More information here

  Example:

  <picture>
     <source media="(max-width: 35em)" srcset="../images/image-product-mobile.jpg">
     <img src="../images/image-product-desktop.jpg" alt="your_alt_text">
  </picture>
  

  • You could use the <del> tag to display the old price:

  <del class="price-old">
     <span class="sr-only">Old price: </span>$169.99
  </del>
  

  Note that I added the <span> with the sr-only class to the del element, this will provide more information about what your old price is about.

  The sr-only class is a class that you can add to hide content visually but is only visible to screen-readers:

  More information here.

  I hope those tips will help you.

  Good Job and happy coding !

  Marked as helpful

  1

  ---

  

  Sang Le•520

  @sqle157Posted about 2 years ago

  @MelvinAguilar Thank you for your feedback! I will consider them into my code for future challenges.

  1