Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

perfum

@Hamdi-git

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@hatemhenchir

Posted

This comment was deleted

1

@VCarames

Posted

@hatemhenchir

Thank you for contributing to the FEM community.

I’m flatter that you found my recommendation helpful but I would really appreciate it, if you would not copy and paste my recommendation, word for word (even the emojis).

The same for my closing statement:

  • "If you have any questions or need further clarification, feel free to reach out to me."

I suggest you write them in your words ,not mine. Be your own identity. Not a copy of me.

Happy Coding!🎄🎁

0

@malek-bt

Posted

Hey Hamdi !, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:

1.The <img> alt attribute is used to specify the alternate text for an image. It is useful when the image is not displayed. It is used to give alternative information for an image.So make sure to make it not empty.

2.Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information. Once you update the container <div class="attribution">, the footer should be outside the main content.

3.Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers.

4.I see your README file is MAL structured. README is a very important aspect of making projects, especially if you want other people to see it. You should read the README file and the README-template file to make nice one.

The rest is good, I hope those tips will help you! 👍

Good job, and happy coding! 😁

1

@hatemhenchir

Posted

Hey Hamdi, nice work. I have some tips for you.

  • replace <div class="card"> with <section class="card"> for semantic page. You can read more about semantic HTML here: HTML Semantic Elements.
  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element
  • Move all the style in class container in the body and just add this line margin:0 auto; in class container, it will be better.
  • Implement a Mobile First approach

The rest is great!

Happy Coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord