Design comparison
SolutionDesign
Solution retrospective
I had a hard time finding how to add an emoji to Add to Cart button. It'd be great if I get recommendations from others on how to do that
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Unfortunately, your challenge is not complete since it is not responsive 😢, which is a requirement for this challenge; a
media query
will help. Here is a link to Google Developer’s site that will teach you how make it 100% responsive:
- The image’s
alt tag
description needs to be improved upon ⚠️. Assume that you are describing the image to a someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This component requires the use of two images 🎑 at different breakpoints ⚠️. The
picture
element will facilitate this.
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- Do not uppercase ❌ "perfume" in HTML as it is not accessible friendly. Instead you will want to style it in CSS.
- Currently, the old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful1@DerekLarteyPosted almost 2 years ago@vcarames Appreciate the feedback! Looking into fixing these problems. Thanks!
0 - Unfortunately, your challenge is not complete since it is not responsive 😢, which is a requirement for this challenge; a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord