Product preview card component - Frontend Mentor

Community feedback

• 

  Adriano•38,270

  @AdrianoEscarabotePosted about 2 years ago

  Hi txosca, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To improve the code structure wrap this div:

  <div class="attribution">

  with the semantic tag footer

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  Add a padding to the body, so that the content in lower resolutions doesn't hit the edge of the screen!

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  txosca•70

  @txoscaPosted about 2 years ago

  @AdrianoEscarabote Thanks a lot for taking your time to help me!!!!!!!!!!!! I'll have a close look on your suggestions!!!!!! Abraço

  1