Product preview card component (float version)

Community feedback

• 

  Vincent Daniel•410

  @davinceeyPosted about 2 years ago

  Hello EnD1nG. Congratulations on your first project! Your solution is nice and great in the whole. Some little tips for you:

  1. You could do well to wrap everything in a <main> tag instead. This would help in good HTML validation and would also help screen-readers to know that they are about going through the main content of your site. Also, you could replace the div in this code <div class="card-inner">, with a section semantic tag. This would help to improve Accessibility.

  2. You can replace the h2 tag with an h1 tag so that it obeys the HTML hierarchy, giving your code a level one heading.

  Hope this helps you. Happy Coding!👊

  Marked as helpful

  1