product preview card component flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .card {
  margin-top: 100px !important;
  margin: auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• Account deleted

  Hello Coder🙂

  your solution is great 🎉

  But you used the wrong method to switch images and there are some better ways are available to handle the image switch problem

  You can try <picture> tag to switch image

  Picture tag :

  <picture>
  
  <source media="(min-width: 597px)"
  srcset="./images/image-product-desktop.jpg ">
  
  
  <source media="(min-width: 0px)" 
  srcset=" ./images/image-product-mobile.jpg">
  
  <img src="./images/image-product-mobile.jpg" alt="Product_image">
  
  </picture>
  
  

  You also can check out my solution✨ that will definitely going to help you 👀

  I hope that will be helpful for you✌️

  0
• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • Using margins is not a good way to center the card instead use flex or grid in body.
  • To center the card on the page.
  • USING FLEXBOX

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  I hope you find this helpful.

  Happy coding😄

  0