Product Preview Card Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 12 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Having an h4 header within a button is not ideal. Consider either removing the header or using a <span> tag for the text to maintain proper semantic structure

  • Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the text-transform property to transform the text to uppercase in CSS.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • Not all images should have alt text. The cart-icon is a decorative image, it does not add any information to the page. You should use an empty alt attribute instead of a descriptive one. You can read more about this here 📘.

    If you want to learn more about the alt attribute, you can read this article. 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Eryk•100

  @fryca9Posted 12 months ago

  @MelvinAguilar thank you so much for your feedback. Your tips are very useful and I have learned something new from them 😁. For instance, I had no idea that when you use uppercase text in HTML - the screen reader will read the word letter-by-letter. I appreciate that you reviewed my code as it really helps me. I have applied all the changes you mentioned to my code. Have a nice day 😁

  1
• 

  Bryan Li•3,530

  @Zy8712Posted 12 months ago

  Your site looks great! Only thing I'd add is cursor-pointer when hovering over the button.

  Marked as helpful

  1

  ---

  

  Eryk•100

  @fryca9Posted 12 months ago

  @Zy8712 Thank you for your feedback 😁. I'm glad that you liked my site. I have changed the cursor to a pointer while hovering over the button. I appreciate that you reviewed my code as it really helps me. Have a nice day 😁!

  0