CSS Flex - Product preview card component

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Welcome to FEM!

  • The alt tag description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a paragraph element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  More Info:📚

  Mobile First

  • Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0

  ---

  

  𝗸𝗵𝗮𝗹𝗶𝘀𝗵𝗮. ♡•120

  @stkhalishaPosted almost 2 years ago

  Hello @vcarames ! Hope you are doing well. Thank you so much for your amazing suggestions and also new informations for me! By the way nice to meet you :)

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @stkhalisha

  Glad I could help!☃️

  I am. Thank you for asking. Hope you’re doing well also. Nice to meet you too!

  Keep it up!

  0
• 

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  HEY LISA!

  Congratulations on completing your first challenge

  Your solution looks very nice

  To fix the current accessibility error that you have, you will have to give your image an alt text, this is essential for screen readers when describing your page to disabled people.

  HOPE I COULD BE OF HELP :)

  HAPPY CODING!

  Marked as helpful

  0

  ---

  

  𝗸𝗵𝗮𝗹𝗶𝘀𝗵𝗮. ♡•120

  @stkhalishaPosted almost 2 years ago

  @Nadine-Green Hey Nadine! Nice to meet you, Thanks a bunch for the feedback :)

  0

  

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  @stkhalisha

  Nice to meet you too and welcome to the community :)

  0