Product-preview-card-component

Community feedback

• 

  Lyna•260

  @lynaIFRPosted 3 months ago

  Nice job, here are things to improve:

  • never use px for font-size, use rem instead
  • don't give specific values to margin and padding, learn about flex and grid layouts, they are more efficient
  • the border-radius should be set for the container, add to it overflow: hidden; to see the magic
  • the first <section> tag should be replaced with a <main> tag, remember, every web page needs a main landmark
  • learn about <picture> it allows you to switch images for different screen sizes so your website can be responsive
  • you may want to use a media query to make the mobile design like provided in the challenge Hope this helps, good luck

  0