Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product-preview-card-component

P
Rashid 100

@Rashid0101

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lyna 260

@lynaIFR

Posted

Nice job, here are things to improve:

  • never use px for font-size, use rem instead
  • don't give specific values to margin and padding, learn about flex and grid layouts, they are more efficient
  • the border-radius should be set for the container, add to it overflow: hidden; to see the magic
  • the first <section> tag should be replaced with a <main> tag, remember, every web page needs a main landmark
  • learn about <picture> it allows you to switch images for different screen sizes so your website can be responsive
  • you may want to use a media query to make the mobile design like provided in the challenge Hope this helps, good luck
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord