Design comparison
Solution retrospective
I am starting to understand SASS and how to use it but I have a question about if how I am writing my SASS code is good to keep using or if should I stay with CSS.
In my content SASS style, what would you improve on to write cleaner code?
Thanks for checking out my solution to this problem :)!
Community feedback
- @GlozsaPosted almost 2 years ago
Hi there!
Some suggestions that will make your site look better
.tagline
instead of using:
position: absolute; bottom: 10%;
instead add:
padding: 2rem 0;
this will avoid your text to collide with the product card
.card-image
You can avoid using:
object-fit: ;
media (max-width: 675px)
body
you can avoid using:
padding: 1.1rem;
and if you fill like it, you can twik the scale of the body in order for it to be responsive with the smallest smartphones:
scale: 0.85;
semantic
you should contain all contents inside a <main>
Marked as helpful0@CodingTimmyethPosted almost 2 years ago@Glozsa thanks for the feedback! I will improve on these areas!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord