Product preview card component

Community feedback

• 

  Kimo Spark•2,190

  @kimodev1990Posted 11 months ago

  Really nice work completing the challenge, Just a few feedback :-

  • You could your container in the middle of your website by adding the body :

  display: flex ;
  justify-content: center ;
  align-items: center ;
  min-height: 100vh ;
  

  then your container under body will be centered.

  • Wrap your content inside <main> </main> tag
  • In future coding, It's better to assign percentage values rather than definite values such as the width of your image width: 250px ; , you could assign width: 50% ; so It would have 50% width in relative to width of your container and the same with div class .text. This is better to have more flexible & responsive design.
  • Adding up to the previous point, You could use clamp ( ) method in your coding for font-size, width, margins, padding, etc., So the designed sizes will change according to the viewport dimensions having a responsive design and will be suitable for any device layout.

  Hope you find this Helpful.

  Other than that, Really Nice work & keep Going on .

  Marked as helpful

  0