Product preview card component challenge

Community feedback

• 

  Aatypic•490

  @AatypicPosted about 2 years ago

  Hello and congratulations on your solution, for your first challenge it's looking very good !

  Concerning your question for the <h1> and <p>, I think to match the design you can give them an attribute of max-width: 25ch , ch being the unit for characters, and you play the value 25 around to see how it looks.

  Anyway this is minor stuff.

  Good luck ✌️

  Marked as helpful

  0

  ---

  

  Zarko Petrov•210

  @zp021Posted about 2 years ago

  @Aatypic Thanks! Didn't know about ch, will try!

  0
• 

  Nelson Nzewi•270

  @nzewiPosted about 2 years ago

  Congrats on completing your first challenge Zarko

  You have a great solution there

  1.The lines of text don't match the design because you have little padding on the `<div class='text'> Try adding more padding to the left and right sides.

  2.Ensure that all content on your page is contained within a landmark region, e.g <main>

  Marked as helpful

  0

  ---

  

  Zarko Petrov•210

  @zp021Posted about 2 years ago

  @nzewi Thank you, that makes perfect sense, probably created that div thinking something along those lines, but as they say solutions are often right under our nose.

  0