Product preview card component challenge using Flexbox

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0

  ---

  

  Clive Chambers•230

  @Clive-ChambersPosted almost 2 years ago

  @vcarames Hey there :) Thanks for the feedback on improving my code:

  I have made sure my content is wrapped in the main element, thank you for providing the MDN Main Element source, that gave me a better understanding of how the main element should be used.

  I have also fully discribed the image in the image alt tag and made use of the picture element to use the two images at different breakpoints.

  Finally i took your advice regarding the original price no being properly announced to screen readers and have added the del element with a span element with a class of sr-only and have applied css to only display the span message to screen readers.

  Can you kindly take another look at my code and provide additional feedback, thank you again for the advice

  0