Product preview card component challenge

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Samuel Jolayemi,

  Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:

  • You can use the <main> landmark to wrap the body content (which is the three cards) instead of <header>

  • About <h1>it is recommended not to have more than one h1 on the page. Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility. In this challenge , as it’s not a whole page, you can have<h1>visually hidden with sr-only. Then swap those <h1> with <h2>.

  • In my opinion, the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images.

  • Add border-radius andoverflow hiddento the main container that wraps the three cards so you don't have to set it to individual corners.

  Aside these, great job on this one. Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Samuel Jolayemi•190

  @SamjolasPosted about 2 years ago

  Hello @PhoenixDev22,

  Thanks for the feedback.

  I have read through and understood all that was said, I will implement them in my next challenge, Kindly look out for it as I will also appreciate your feedback on that.

  Thanks, PhoemixDev

  0