Product Preview Card Component Challenge

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

• For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

• So resolve the issue by replacing the <div class="container-main"> element with the semantic element <main> along with <div class="attribution"> with <footer> element in your index.html file to improve accessibility and organization of your page

CSS 🎨:

• Looks like the component has not been centered properly. So let me explain, How you can easily center the component with using fixed positioning for footer

• Luckily you already used Grid layout of css to center the component, So you just want to add fixed position for <footer> element to place it in bottom of the page

footer {
   position: fixed;
   bottom: 1em;
}

• Now your component has been properly centered

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!