HTML,CSS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a paragraph element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  oshaxgio•60

  @oshaxgioPosted almost 2 years ago

  @vcarames thank you very much for help and advice it's very helpful.))

  1
• 

  Kitketovsky•45

  @KitketovskyPosted almost 2 years ago

  Hey! Seems ok expect for a few moments:

  1. No mobile version (try using CSS Flexbox for changing layout on particular media query)
  2. Button's font is incorrect (it is 'Montserrat')
  3. Don't forget about such property as 'line-height' in paragraph and main title

  Marked as helpful

  0

  ---

  

  oshaxgio•60

  @oshaxgioPosted almost 2 years ago

  @Kitketovsky thank you very much

  0