Design comparison
Solution retrospective
This is a very fun project. All feedback are welcomed.
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @ArafAfif!
Your solution looks great!
I have a couple of suggestions for improvement:
- In order to make your HTML code more semantic, and since that is the main title of the screen, replace the
<h2>
with<h1>
. Unlike what most people think, it's not just about the size and weight of the text.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Also, still about semantic HTML, replace your
div.card
withmain.card
.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1 - In order to make your HTML code more semantic, and since that is the main title of the screen, replace the
- @Naveen-CBPosted 11 months ago
Hello @ArafAfif your code almost accurate to the solution but here are some solution to improve your project further : - 1. mentioning font with font-size in em or rem is increase your text readability in all type of screens.- 2.Try to use source for different size of images for different screen ref here.-
-I hope this might be useful to you.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord