Design comparison
Solution retrospective
Any feedback is welcome!
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Earl Cardino, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:
We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements.
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>
Images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty
alt=""
and addaria-hidden="true"
attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.The rest is great!
I hope it helps... 👍
Marked as helpful1@earlyronniePosted about 2 years ago@AdrianoEscarabote Hello Adriano!
Thank you for the wonderful tips! I'll make sure to apply them every time I create a project. For now, I'll be using those tips to improve my solution.
1@AdrianoEscarabotePosted about 2 years ago@earlyronnie I'm glad you liked it! happy coding!!
1@benjaminbilgehanPosted about 2 years ago@earlyronnie practice makes it perfect! keep doing it.
0 - @benjaminbilgehanPosted about 2 years ago
you should use @media (max-width:640px) for mobile responsive. bigger then 640px just keep the desktop version for any type of screen size. try to inspect with chrome dev tool.
on figma design width and height of the container are given.
@media (max-width:640px) { .container { width: 343px; height: 611px; }
Marked as helpful1@earlyronniePosted about 2 years ago@benjaminbilgehan Thank you so much for the tips!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord