Submitted 9 months ago
Product preview card component built with SCSS, Flexbox, BEM Notation
@ankkiel
Design comparison
SolutionDesign
Solution retrospective
Hi, I would like feedback, if there are something I can improve.
Thanks!
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @ankkiel!
Your solution looks excellent!
I have just one suggestion:
- Use
<main>
to wrap the main content instead of<main>
and<article>
.
š The tag
<article>
would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord