Grid layout module, mobile first.

Community feedback

• 

  Precious Nkwor•440

  @Jeen-PreshPosted almost 2 years ago

  Hello Darionas, congratulations on completing the fem challenge and also on collaborating with others. very impressive.

  Some few suggestions to help improve your project

  • Your code below is meant to be wrapped with an h1 tag.

  <h3 class="product-type">PERFUME</h3>
  

  • The product description should be wrapped with a p tag, you can replace the div element with a p tag and leave the class in the p tag.

  • For the old price, you should add a span tag with a class of sr-only inside your del element and a text that says the old price, and use CSS to make it hidden. this ensures it's being read out for screen-readers.

  for more info on sr-only class. sr-only KittyGiraudel\

  • for mobile screens, it isn't centered properly.

  Happy coding. if you found this helpful, make sure to mark as helpful thanks.

  Marked as helpful

  0

  ---

  

  Darionas•340

  @DarionasPosted almost 2 years ago

  @Jeen-Presh, Thank you for fast response. I am going to implement your recommendations. I very appreciate it. Thanks again.

  It has implemented already.

  0