Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Component

@SteveNoyes

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas 👾 104,420

@correlucas

Posted

👾Hello Steven , Congratulations on completing this challenge!

You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code to improve the html markup/semantic:

The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

✌️ I hope this helps you and happy coding!

Marked as helpful

1

@SteveNoyes

Posted

@correlucas Thank you.

0
Adriano 34,090

@AdrianoEscarabote

Posted

Hi @SteveNoyes, how are you?

Welcome to the front-end community You did a great job on this challenge, but I have a few tips I think you'll like:

1- Document should have one main landmark, you could have put all the content inside the main tag click here

I noticed that the content was not so centralized, to fix this we could do the following:

.attribution { /* margin-top: auto; */ }

The rest is great! Hope it helps... 👍

Marked as helpful

1

@SteveNoyes

Posted

@AdrianoEscarabote Thank you for the feedback! I appreciate it.

1
Adriano 34,090

@AdrianoEscarabote

Posted

@SteveNoyes no problem, keep coding!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord