Design comparison
SolutionDesign
Community feedback
- @Shivraj-K09Posted over 1 year ago
Your
HTML
andCSS
code look correct, and theproduct preview card component
looks good. However, here are some suggestions that you could consider -- Use
semantic HTML elements
likeheader
,main
,nav
andfooter
to improve the readability and accessibility of your code. You might want to consider reducing thefont size
of your content on smaller screens. Afont size
of14px
on smaller screens may result in poor legibility. - You may also want to consider adding a
media query
to adjust thedimensions
andlayout
of the section element based on the device screen size to enhance user experience. - Otherwise, your code looks good and is well-organized. Happy Coding 😉
Marked as helpful0 - Use
- @HassiaiPosted over 1 year ago
For a responsive content in the media query replace the width in the section with max-width.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord