responsive product preview card

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="card-content">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .card-container on the page using flexbox, add min-height: 100vh to the body.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  P

  Jolijn Rosendaal•340

  @Jolijn0101Posted almost 2 years ago

  @Hassiai Thank you for your Feedback. It was very helpful. Especially the rem/em advice. With turning the div tag into a main tag my accessibility issues are also gone.

  0