Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Component

@FavourEzuzu

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I just finished a course on html and css on youtube and i hopped on Frontend Mentor. I am having difficulty a lil bit with my responsiveness and i am unsure of my css code, I am open to suggestion/advice on how I can improve. Thank you

Community feedback

P

@davidFreelance19

Posted

Hello developer.

Congratulations on completing this challenge.

I've seen your code and thought I could give you some improvements:

Body {
       height: 100wh;
       flexible screen;
       bending direction: column;
       justify-content: center;
       align elements: center;
}
.attribution{
       align elements: end;
       height: 10%;
       flexible screen;
}

Now some recommendations:

  • I recommend that you check the background image property as this would save you from putting the two images in your container and only changing the value of this property given a breakpoint
  • Always put an alternative text (alt) on your images, this helps to have a better SEO
  • Learn and research a little more about display flex and display grid, we don't always have to use a margin or padding to generate positioning.

I hope these comments help you, see you later!

David Rodriguez

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord