P
David Rodriguez B.• 430
@davidFreelance19
Posted
Hello developer.
Congratulations on completing this challenge
.
I've seen your code and thought I could give you some improvements:
Body {
height: 100wh;
flexible screen;
bending direction: column;
justify-content: center;
align elements: center;
}
.attribution{
align elements: end;
height: 10%;
flexible screen;
}
Now some recommendations:
- I recommend that you check the
background image property
as this would save you from putting the two images in your container and only changing the value of this property given a breakpoint - Always put an alternative text (alt) on your images, this helps to have a better SEO
- Learn and research a little more about
display flex
anddisplay grid
, we don't always have to use a margin or padding to generate positioning.
I hope these comments help you, see you later!
David Rodriguez
Marked as helpful
1