Product Preview Card Component

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.
  • Since the mobile design has a different image, you can use the <picture> tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here

  CSS 🎨:

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here

  I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

  Happy <coding /> 😎!

  1

  ---

  

  HelloTechTinu•670

  @tinuolaPosted over 1 year ago

  @frank-itachi: Thanks for taking time to give feedback.

  There is an h1 tag in the code.

  For a project this simple, I see little issue with using px vs rems. In some cases, using px can be easier to read than mentally calculating/converting what a value is in rem/em.

  I'll look into refactoring with the <picture> tag--it's one that I've not used before; and I see (and agree) that it could be an alternate approach here.

  0