Product preview card component... ALL COMMENTS ARE WELCOME

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing<div class="attribution"> with semantic element <footer> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Parimal•190

  @parimaldesignPosted over 1 year ago

  Hi Fabian, Congratulations on completing this challenge. Both the code and output are near perfect.

  Just nitpicking here - Here are some changes I would suggest which shouldn't take long -

  • You have to add a hover effect on the button according to the challenge brief.
  • Text content in the card layout has too much gap when in the mobile version.

  If you are a beginner, this is really great work.

  0

  ---

  

  Fabian Andrade•70

  @aluiggi96Posted over 1 year ago

  @parimaldesign yes... The hover I forgot to add it as pseudo element 😅 The gap Im going to adjust a lil bit less yet

  0