Frontend Mentor - Product preview card component solution (Sass)

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • Your attribution should be wrapped in a footer element instead of a div.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0

  ---

  

  Yixuan WANG•240

  @yxwangOCRPosted almost 2 years ago

  @vcarames Hello,

  I really appreciate your review suggestions. I modified almost everything you mentioned except for the sr-only class because I still need time to work on it.

  Thanks again for your advice and I would like to get more of your opinions on other challenges!

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @yxwangOCR

  Glad I could help!☃️

  Keep it up!

  0