lirone• 320
@LironeFitoussi
Posted
dont forget the <body> background color background-color: hsl(30, 38%, 92%);
p.s. all fonts and size you can find on the docs youvgot
Marked as helpful
0
Design comparison
Community feedback
Hassia Issah• 50,670
@Hassiai
Posted
Replace <div class="container-fluid"> with the main tag and <h3> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html
You forgot to add the mobile image to html file, add the mobile image tothe div containing the desktop image and give both img a class of the styling.
Use the colors that were given in the styleguide.md found in the zip folder you downloaded
To center .container-fluid on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .container-fluid on the page using flexbox:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
To center .container-fluid on the page using grid:
body{
min-height: 100vh;
display: grid;
place-items: center;
}
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord