Product Preview Card Component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Rykryslr, Congratulations on completing this challenge!

  I saw your solution preview site and I think its already really good. Here’s some tips for you to improve it:

  1.Improve the card overall look adding the rounded borders to the component and also the image using border-radius: 15px

  • Add rounded borders to the left side of the image with border-radius: 15px 0px 0px 15px;
  • Then do the same thing for the component but in the opposite borders border-radius: 0px 15px 15px 0px;

  2.THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  • Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  1
• 

  Laharl•1,000

  @UrbanskiDevPosted about 2 years ago

  Hello rykryslr !

  Congratulation for finishing this challenge

  I have some advice to give you :

  1. I recommend you to use the latest HTML semantic available, using <main> instead of a div with a class container. I give you a link to learn more about the latest HTML semantic !

  • W3Schools HTML5 Semantic

  2. In your HTML file, you put multiple <h1> tag in your page, which is not recommended the way you used it.

  You can remove the <h1> you added for the price, and then add CSS to make your layout.

  In the same idea, don't use <h5> before using an <h2>, <h3>, <h4>, if you want it to looks like it, use CSS. HTML is for structuring the page while CSS is for giving styles to your page.

  3. Still in your HTML file, you used a lot of <br> tags, while it is not a bad practice, it is not what I would recommend ! I'll recommend you to use CSS to make it looks like you did but without using <br> tag.

  I put a link which explain why it's not really used :

  • StackOverflow br tag

  I hope it helps you, keep learning and happy coding !

  1