Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

used html and css only

AbdulRhmanβ€’ 270

@Abdo-al-R

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello , this is my solution for this challenge , If you have any suggestions or modifications to make the code better, I am more than welcome for your advice , thanks .

Community feedback

Nikola Dβ€’ 1,450

@NikolaD93

Posted

Hello there! πŸ‘‹

Congrats for completing the challenge! Everything looks great and the code is clean. πŸ™Œ

Hope this was helpful for you!

Happy holidays! πŸŽ‰βœŒ

Marked as helpful

1
Hassia Issahβ€’ 50,670

@Hassiai

Posted

Replace <div class="container"> with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

There is no need to give .container a height value, the heigh will make content overflow when it is resize.

Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

in the media query give the width of .container a value. e.g: width: 320px; and flex-direction: column, no need for display: flex again and justify-content: space-between.

Give .image2 display: block ;instead of inline-block by default the img is an in-line element. in the media query you want to it to occupy and entire space.

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

AbdulRhmanβ€’ 270

@Abdo-al-R

Posted

@Hassiai thanks alot .. alot of new informitions for me .. thank you

0

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

Congrats on completing your first challenge!πŸŽŠπŸŽ†

  • Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
  • To properly center βœ… your content to your page, you will want to add the following to your body (this method uses CSS Grid):
body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

More Info: πŸ“š

Centering in CSS

  • The image’s alt tag description needs to be improved upon. Assume that you are describing the image to a someone over the phone.

More Info:πŸ“š

https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images πŸŽ‘ at different breakpoints. The picture element will facilitate this.

Here is an example of how it works: EXAMPLE

Syntax:

  <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

More Info:πŸ“š

https://www.w3schools.com/html/html_images_picture.asp

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸŽ„πŸŽ

Marked as helpful

0

@VCarames

Posted

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like β€œThe previous price was…” and use CSS to make it only visible to screen readers.

More Info:πŸ“š

Del Element

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

Here are some examples that you can freely use:

Josh Comeau Reset

Eric Meyer Reset

  • For improved accessibility πŸ“ˆ for your content, it is best practice to use rem for your font-size and other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.
  • Implement a Mobile First approach πŸ“± > πŸ–₯ Mobile devices are now the dominant πŸ‘‘way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.

More Info: πŸ“š

Mobile First

Marked as helpful

0
AbdulRhmanβ€’ 270

@Abdo-al-R

Posted

@vcarames thank you very much that was helpful my friend

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord