Design comparison
SolutionDesign
Community feedback
- @bccpadgePosted 9 months ago
Hello @oyesina-paul. Congratulations on completing this challenge!!!π
I have few suggestions you might be interested in to improve your solution.
HTML π:
- On the
body
you can removemargin: 1rem;
and addmargin-inline: 1rem;
for mobile devices.- Margin-inline is a CSS logical property which means margin will be on the left and right.
- Also, you can add
min-height:100vh
on thebody
to place the component in the middle of the website and you can removemargin-top: 5rem;
because it is unnecessary code.
More infoπ:
Here is my solution to this challenge: Product preview component
I hope you find this useful and don't hesitate to reach out if you have any questions.
Marked as helpful0@oyesina-paulPosted 9 months agoHello @bccpadge
Thanks a lot for taking your time to review my solution.
I have made the necessary corrections you gave.
I really appreciate you Rebecca.
1 - On the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord