Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

Francescoā€¢ 270

@FraCav99

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi everyone!

Took a pause from practicing. I came to the basics to learn more about grid and flex and I've discovered new amazing things.

It's incredible how grid can simplify layouts with just few lines of code. Also I'm happy that I learnt something new about semantic html (I have a long road ahead, but I'm happy that I didn't use way too muc divs inside my code!)

Give it a look and give me suggestion on how to improve for next challenges. Until then, happy coding! :D

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @FraCav99!

Your solution looks great!

I have a suggestion (about semantic HTML) for improvement:

šŸ“Œ Use <h1> to <h6> for titles instead of <p>.

The tag <p> is meant for paragraphs. For titles, we have the HTML headings (the tags <h1> to <h6>).

Here's a quick guide on how to use them:

Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

0

Francescoā€¢ 270

@FraCav99

Posted

@danielmrz-dev thanks for the suggestion!

I actually used an h2 instead of an h1 cause I've thougth of it being used as a separate component placed everywhere in the page and which makes sense all alone.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord