Product card rewiew

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi @RUBBOSS 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="card"> to improve the accessibility of the website.

  • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.

  • You can use a <picture> tag when you need to change an image in different viewports. Using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from utilizing a media query to modify the image.

  Example:

  <picture>
     <source media="(max-width: 378px)" srcset="./images/image-product-mobile.jpg">
     <img src="./images/image-product-desktop.jpg" alt="your alt text">
  </picture>
  

  • The product image is considered important content. It is therefore necessary to add an alt attribute to the image to provide additional context.

  • The <h1> element is the main heading on a webpage, also, there should only be one <h1> tag per page. Swap the <h1 class="newPrice"> tag with another tag.

  • Inside a button it is not recommended to have a block element like a <div>

  Above all, the project is done well👏. I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  1

  ---

  

  Ruben•250

  @RUBBOSSPosted almost 2 years ago

  @MelvinAguilar Thanks for the advice)))This is my first work))

  1