Product Card Component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="container">with the main tag and <h2> with <h1> to fix the accessibility issue.

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  There is no need to give the body a width and height values.

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

  Replace the height value of .app with auto instead of 100vh. give .product-info a background-color of white. give .btn-container a padding top and bottom value. e.g. .padding: 16px 0;

  In the media query, give .container a fixed width value instead of a percentage value. e.g: width:600px; . give .app and .img-container a height value of auto instead of 90%.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0