My "Product Preview Card Component" Solution

Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

HTML:

• Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

• You could use the <del> tag to indicate the price that was before the discount. Additionally, you can use a sr-only class to describe the discount. This will help screen reader users to understand that the price was discounted.

Example:

<del><span class="sr-only">Old price: </span>$169.99</del>

• You can use the <picture> tag when you have different versions of the same image. Using the <picture> tag will help you to load the correct image for the user's device saving bandwidth and improving performance. You can read more about this here.

Example:

<picture>
	<source media="(max-width: 460px)" srcset="./images/image-product-mobile.jpg">
	<img src="./images/image-product-desktop.jpg" alt="{your alt text goes here}">
</picture>

CSS:

• Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!