@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- The
article
andsection
elements are being used incorrectly ❌ and not needed for this challenge .
- The image’s
alt tag
description needs to be improved upon ⚠️. Assume that you are describing the image to a someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This component requires the use of two images 🎑 at different breakpoints ⚠️. The
picture
element will facilitate this.
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The only heading ⚠️ in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a
paragraph
element.
- Currently, the old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful
@VCarames
Posted
- NEVER ❌ do this as it creates accessibility issues for users and it is outdated, instead download a
px
torem
/em
converter in your code editor.
html {
font-size: 62.5%;
}
- Your
CSS Reset
is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
- For improved accessibility 📈 for your content, it is best practice ✅ to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
@202745EsquedaDaniel
Posted
@vcarames Thank you so much. Youre amazing! Can you check my code again? How can i use sr-only class in my page? im using correctly the tag del?
Have a nice day.
@VCarames
Posted
@00lar
Glad I could help! 😁
The comment I left regarding the price explain how to apply it.