Design comparison
Solution retrospective
What are some best practices for HTML tags? I used a main tag and an article tag. Are these correct?
What are some best practices with height?
Is it OK to use negative numbers to affect margins (margin-bottom: -0.625em)? I did this a few times on my second article tag.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
Congrats on completing your first challenge!🎊🎆
- The image’s
alt tag
description needs to be improved upon. Assume that you are describing the image to a someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This component requires the use of two images 🎑 at different breakpoints. The
picture
element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
- The
attribution
should be outside themain
element and be wrapped in afooter
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎄🎁
Marked as helpful1@VCaramesPosted almost 2 years ago- Your
CSS Reset
is being underutilized. To fully maximize it, you will want to add more to it.
Here are some examples that you can freely use:
- To properly center your content to your page, you will want to add the following to your
body
(this method uses CSS Grid):
body { min-height: 100vh; display: grid; place-content: center; }
More Info: 📚
For improved accessibility 📈 for your content, it is best practice to use
em
formedia-queries
. Using these unit gives users the ability to scale elements up and down, relative to a set value.Marked as helpful1@CalderonVasquezPosted almost 2 years ago@vcarames Thanks for the feedback and the resource links. I really appreciate it.
1@CalderonVasquezPosted almost 2 years ago@vcarames I implemented the changes you suggested. I can't thank you enough. I learned so many new concepts. Thanks again.
1@VCaramesPosted almost 2 years ago@CalderonVasquez
I’m glad I was able to help you in your coding journey.
Here’s a great website (by Google) that I used (still use) to learn a lot of things I currently know.
1 - The image’s
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord