A product preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Congrats on completing your first challenge!🎊🎆

  • The image’s alt tag description needs to be improved upon. Assume that you are describing the image to a someone over the phone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • The attribution should be outside the main element and be wrapped in a footer element.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎄🎁

  Marked as helpful

  1

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • To properly center your content to your page, you will want to add the following to your body (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info: 📚

  Centering in CSS

  For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using these unit gives users the ability to scale elements up and down, relative to a set value.

  Marked as helpful

  1

  

  P

  E. Marshall•120

  @CalderonVasquezPosted almost 2 years ago

  @vcarames Thanks for the feedback and the resource links. I really appreciate it.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @CalderonVasquez

  Glad I could help!☃️

  Keep it up!

  1

  

  P

  E. Marshall•120

  @CalderonVasquezPosted almost 2 years ago

  @vcarames I implemented the changes you suggested. I can't thank you enough. I learned so many new concepts. Thanks again.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @CalderonVasquez

  I’m glad I was able to help you in your coding journey.

  Here’s a great website (by Google) that I used (still use) to learn a lot of things I currently know.

  https://web.dev/learn/

  1