@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
Congrats on completing your first challenge!🎊🎆
- The image’s
alt tagdescription needs to be improved upon. Assume that you are describing the image to a someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This component requires the use of two images 🎑 at different breakpoints. The
pictureelement will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
delelement and inside it you will add aspanelement with ansr-only classthat will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
- The
attributionshould be outside themainelement and be wrapped in afooterelement.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎄🎁
Marked as helpful
@VCarames
Posted
- Your
CSS Resetis being underutilized. To fully maximize it, you will want to add more to it.
Here are some examples that you can freely use:
- To properly center your content to your page, you will want to add the following to your
body(this method uses CSS Grid):
body {
min-height: 100vh;
display: grid;
place-content: center;
}
More Info: 📚
For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using these unit gives users the ability to scale elements up and down, relative to a set value.
Marked as helpful
@CalderonVasquez
Posted
@vcarames Thanks for the feedback and the resource links. I really appreciate it.
@VCarames
Posted
@CalderonVasquez
Glad I could help!☃️
Keep it up!
@CalderonVasquez
Posted
@vcarames I implemented the changes you suggested. I can't thank you enough. I learned so many new concepts. Thanks again.
@VCarames
Posted
@CalderonVasquez
I’m glad I was able to help you in your coding journey.
Here’s a great website (by Google) that I used (still use) to learn a lot of things I currently know.
