Product preview card component

Community feedback

• 

  Precious Nkwor•440

  @Jeen-PreshPosted almost 2 years ago

  Hello George, congratulations on competing your fem challenge

  Some suggestions to improve your project

  • You should always wrap your main content with the main element.

  more info MDN main element

  • Make use of the picture element, since the challenge has two different images for different screen sizes.

  more info MDN link picture element

  -Make use of the del element to wrap the old price, add a span tag with a class of sr-only, and inside should have a text of the previous price. then use CSS to make the span element hidden, this makes it easier for screen-readers to pick the information properly.

  more info MDN del element

  more info sr-only class

  • The only heading should be perfume.

  Happy coding. I hope you found this helpful.

  0

  ---

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey @Jeen-Presh ! 👋

  As a friendly reminder, please avoid the following as it is against FEM’s policy:

  • "if you found this helpful, make sure to mark as helpful thanks."

  Which can result in your getting your account flagged and banned temporarily/permanently.

  "Ask people to mark your comment as helpful — A big part of Frontend Mentor is helping each other out and providing feedback. If you give some feedback, please avoid saying things like, "if you found this feedback useful, please mark this comment as helpful". It places unnecessary pressure on the solution author to mark your comment as helpful, which is best avoided. Feel free to say something like, "I hope you find this helpful", but please avoid asking for your comment to be marked as helpful outright."

  The goal of providing feedback is to help individuals learn and grow as developers; not about gaining points.

  Thank you for contributing to the FEM community!

  Happy Coding! 🎆🎊🪅

  0

  

  Precious Nkwor•440

  @Jeen-PreshPosted almost 2 years ago

  @vcarames Thanks for the correction, the feedback has been updated appropriately.

  0