My third project

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  HI! Your solution looks nice though there are a couple of things you can improve which I hope will be helpful! 😊

  I would also add some transitions for active states (when colors change on hover), specifically to:

  <button class="button" data-icon="shopping-cart">Add to Cart</button>
  
  

  It creates more interactivity and makes the project look cooler. Active states can be done on buttons, links, titles which act like links, or anything else, you choose.

  You can read more about it here, in case you haven’t done much of it:
https://www.w3schools.com/css/css3_transitions.asp

  If you want to improve your code, make sure to use <footer> tag instead of <div> tag, the one where the class is “attribution”. There are a lot of other important semantic HTML tags which you can read about here or anywhere else: https://www.w3schools.com/html/html5_semantic_elements.asp

  Marked as helpful

  1

  ---

  

  Luis Felipe•230

  @FelipinDRPosted almost 2 years ago

  @catherineisonline Thank you for your tips, gonna improve it next time <3

  0

  

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  @FelipinDR Sure thing, good luck! 😎

  0