Product preview card component

Community feedback

• 

  David•8,000

  @DavidMorgadePosted over 2 years ago

  Hello man congrats on finishing this challenge! here are a few advices that you can take for future projects!

  • Try using relative units such as rems and % instead of pixels, with these units it will be easier to make your site more responsive.

  • Avoid as much as you can using <br> tags, if you need spaces or line jumps, try with CSS, br tags are usually a bad practice in 99% of the cases!

  • Consider centering your component using flex on the body instead of margins, it will be easier and can be done with a few lines of code!

  But anyway as a first challenge you did a pretty good job, keep it going and you will se how you improve in no time.

  Hope my feedback helped you!

  Marked as helpful

  2

  ---

  

  nouredine•90

  @elghaouatPosted over 2 years ago

  @DavidMorgade thank's alot sir, I appreciate your comment, and I'll work hard on the points you told me :)

  1