Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

@Alord81

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Favour 2,140

@Nadine-Green

Posted

HEY THERE!

CONGRATULATIONS ON COMPLETING YOR FIRST CHALLANGE :)

I noticed that you have a few accessibility issues, I can help you with some of them:

  • Instead of using a div for <div class="card">, you could instead use a more semantic element like main.

  • You should use a h1 instead of a h2 for this code:

<h2>Gabrielle Essence Eau De Parfum </h2>

After doing so, you will need to generate a new report, the button to do s should be just above the report itself.

HOPE I COULD BE OF HELP :)

HAPPY CODING!

Marked as helpful

1

@Alord81

Posted

@Nadine-Green Hello ! Thanks for your fine advice,I will try to avoid and correct the points you mentioned in the coming times. Thanks Again ;)

0
Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="card"> with the main tag and <h2></h2> with <h1></h1> to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

To center .card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body, instead giving the body margin: 50px auto;.

reduce the width value of .card to 600px and changer the height value to auto; Give .text background-color of white instead of giving .card background-color of white.

Use rem or em as unit for the padding , margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

Hope am helpful. HAPPY CODING

Marked as helpful

0

@Alord81

Posted

@Hassiai Thank you as big as the sky. You don't know how much help you gave me at the beginning of my path. <thank you so much>

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord