preview-card-component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Your HTML should have a main element that will assist in identifying the main content of your site. For this project, the main element will serve as the component’s container.

  More Info:📚

  MDN Main Element

  • Do not capitalize the "PERFUME" in HTML as it can cause issues with screen readers, instead use CSS to style it.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • Since the images in this component add value and serve a purpose (displaying the product), it is best to use the Picture element and not the background-image property, as it will to use different images during different breakpoints.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0