Product Preview Card Component

Community feedback

• 

  Eni•180

  @EnidaShehuPosted over 1 year ago

  Congratulations on completing this challenge Nikhil :)

  A few helpful tips I would give you are:

  1 - Fix the spelling of the "container" class: In the <div> element with the class container, there is a typo. Change the class name from conatiner to container to correct it.

  2 - The image doesn't swap when the screen size changes. To achive that add both images on your html as below:

  <img src="images/image-product-desktop.jpg" class="image-1" alt="parfume-bottle" /> <img src="images/image-product-mobile.jpg" class="image-2" alt="parfume-bottle" />

  After that add the CSS:

  /* for current screen size*/

  .image-1 { width: 100%; border-top-left-radius: 10px; border-bottom-left-radius: 10px; }

  .image-2 { display: none; }

  /for smaller screen size/

  @media screen and (max-width: 375px) {

  .image-1 { display: none; }

  .image-2 { border-top-left-radius: 10px; border-top-right-radius: 10px; border-bottom-left-radius: 0px; display: flex; width: 100%; }

  .image-1::before { content: url("images/image-product-mobile.jpg"); } }

  I hope this helps. Keep up the good work :)

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using single image for both Desktop & Mobile devices, but we want to swap images according to their screen sizes. Luckily there's a native html element which may help us to achieve this method without need of css

  ---

  • So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0