Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component with HTML and CSS

Kure-ruβ€’ 120

@Kure-ru

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback welcome.

Community feedback

S MD sulemanβ€’ 3,530

@sulemaan7070

Posted

hey πŸ˜„, congratulations on completing your first challenge... here are a few tips to make your site better.

1.I see that you have used .container -> height:90vh ...using height:90vh 🚫 is a bad practice you can use min-height:90vhβœ… or 100vh.

2.Using the picture element for responsively switching between Images is considered as best practice

<picture>
  <source media="(min-width: 650px)" srcset="img_food.jpg">
  <source media="(min-width: 465px)" srcset="img_car.jpg">
  <img src="img_girl.jpg">
</picture>

more about picture element hereπŸ“š

Hope that helps, happy codingπŸ”₯πŸ”₯

Marked as helpful

1

Kure-ruβ€’ 120

@Kure-ru

Posted

@sulemaan7070 Hi, thank you so much for your feedback!

I learned a lot thanks to your comment! 😁

2
Abrahamβ€’ 270

@Abeeujah

Posted

Hello, Nice Solution you've got.. Here's some tips to improve it

HTML :

Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

CSS : You can use Intrinsic Sizing or an accurate Extrinsic Sizing to handle Overflow on your component

Marked as helpful

0

Kure-ruβ€’ 120

@Kure-ru

Posted

@Abeeujah Hi Abraham, thank you so much for your feedback. It's very helpful!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord