Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Nguyen Le Vinh, congratulations for your new solution!
You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use
<picture>
instead of<img>
wrapped in a div. You can manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device (phone / computer) Here’s a guide about how to usepicture
: https://www.w3schools.com/tags/tag_picture.aspInstead of using
#root
you can simply usebody
Body { background-color: var(--cream); width: 100%; height: 100vh; display: flex; justify-content: center; align-items: center; }
✌️ I hope this helps you and happy coding!
Marked as helpful0@VinhNguyenLePosted about 2 years agoThank you for this comment, it was very helpful
1@correlucasPosted about 2 years ago@VinhNguyenLe I'm happy to hear that, keep it up 👏
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord