What I used most is flexbox and variables to organize the code

Community feedback

• 

  Nelson•2,390

  @nelsonleonePosted almost 2 years ago

  **HELLO....congrats on completing this challenge.....well done 🎊 🎊 **

  Your attribution(your name.......) You can see to put it in it's own div ,

  and let it stay outside of your solution. It's more better that way.

  Hope this comment was helpful , have fun coding

  Marked as helpful

  1

  ---

  

  mohamed haithem•180

  @mohamedhyssmPosted almost 2 years ago

  @nelsonleone thank you for your help

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Do not forget ⚠️ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.

  • Since the images in this component add value and serve a purpose (displaying the product) it needs to be accessible ⚠️. The image needs to be applied using the picture element and not the background-image property, as it will not only let you use different images during different breakpoints it will let apply an alt tag description to image stating what the image is.

  • Currently, the old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • Implement a "Mobile First" approach 📱 > 🖥

  Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.

  More Info: 📚

  Mobile First

  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  1

  ---

  

  mohamed haithem•180

  @mohamedhyssmPosted almost 2 years ago

  @vcarames thank you for your help

  0