Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

What I used most is flexbox and variables to organize the code

mohamed haithemβ€’ 180

@mohamedhyssm

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What I used most is flexbox and variables to organize the code and scss it is very useful

Community feedback

Nelsonβ€’ 2,390

@nelsonleone

Posted

**HELLO....congrats on completing this challenge.....well done 🎊 🎊 **

Your attribution(your name.......) You can see to put it in it's own div ,

and let it stay outside of your solution. It's more better that way.

Hope this comment was helpful , have fun coding

Marked as helpful

1

mohamed haithemβ€’ 180

@mohamedhyssm

Posted

@nelsonleone thank you for your help

0

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

  • Do not forget ⚠️ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
  • Since the images in this component add value and serve a purpose (displaying the product) it needs to be accessible ⚠️. The image needs to be applied using the picture element and not the background-image property, as it will not only let you use different images during different breakpoints it will let apply an alt tag description to image stating what the image is.
  • Currently, the old price (169.99) 🏷 is not being properly announced 😒 to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like β€œThe previous price was…” and use CSS to make it only visible to screen readers.

More Info:πŸ“š

Del Element

  • Implement a "Mobile First" approach πŸ“± > πŸ–₯

Mobile devices are now the dominant πŸ‘‘ way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.

More Info: πŸ“š

Mobile First

  • For improved accessibility πŸ“ˆ for your content, it is best practice to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸŽ†πŸŽŠπŸͺ…

1

mohamed haithemβ€’ 180

@mohamedhyssm

Posted

@vcarames thank you for your help

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord