What I used most is flexbox and variables to organize the code
Design comparison
Solution retrospective
What I used most is flexbox and variables to organize the code and scss it is very useful
Community feedback
- @nelsonleonePosted almost 2 years ago
**HELLO....congrats on completing this challenge.....well done π π **
Your attribution(your name.......) You can see to put it in it's own div ,
and let it stay outside of your solution. It's more better that way.
Hope this comment was helpful , have fun coding
Marked as helpful1 - @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- Do not forget β οΈ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- Since the images in this component add value and serve a purpose (displaying the product) it needs to be accessible β οΈ. The image needs to be applied using the
picture
element and not thebackground-image
property, as it will not only let you use different images during different breakpoints it will let apply analt tag
description to image stating what the image is.
- Currently, the old price (169.99) π· is not being properly announced π’ to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like βThe previous price wasβ¦β and use CSS to make it only visible to screen readers.
More Info:π
- Implement a "Mobile First" approach π± > π₯
Mobile devices are now the dominant π way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.
More Info: π
- For improved accessibility π for your content, it is best practice to use
em
formedia-queries
. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! πππͺ
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord