Design comparison
SolutionDesign
Solution retrospective
All feedbacks are welcome
Thanks Guys
Community feedback
- @pRicard0Posted over 1 year ago
Some HTML tips
- Instead of using p for the prices, you can use
em
ands
. The<em>
tag is used to define emphasized text. The content inside is typically displayed in italic. A screen reader will pronounce the words in<em>
with an emphasis, using verbal stress. The<s>
HTML element renders text with a strikethrough, or a line through it. Use the<s>
element to represent things that are no longer relevant or no longer accurate. - You can use
main
instead of the div with the product card container class - You can use h1 instead of h2 and h2 instead of h3. You need to respect the hierarchy.
- You can use
footer
instead of te div with the attribution
Some CSS tips.
- You should use rem instead of pixel for fontsize. A pixel isn't responsive.
Marked as helpful0@Khoded1Posted over 1 year agoThank you very much, I'll take notes on the things i need to change and start working on them@pRicard0
0 - Instead of using p for the prices, you can use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord