Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Add the alt attribute with a value of null
alt=" "
to the cart-icon img tag<img>bto fix the error issue. Replace<div class="wrap">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/To center .wrap on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
there is no need to give. wrap a max-height value or a height value. there is no need to give the section a width of 80% ,give it a padding value for all the sides. Use the correct font-family for the text.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord