Skip to content
Submitted almost 2 years ago

Product preview card using HTML and CSS

Harshit Joshi•120
@TheFoxian
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello! I have completed this challenge mentioned over Frotendmentor.io Kindly take a look to my submission and give feedbacks accordingly. Thanks Enjoy Coding :)

Community feedback

  • S MD suleman•3,530
    @sulemaan7070Posted almost 2 years ago

    hey 😄, congratulations on completing your first challenge... here are a few tips to make your site better.

    1.I see that you have used .container -> height:100vh ...using height:100vh 🚫 is a bad practice and can cause problems on the mobile version, you can use min-height:100vh✅

    2.Using the picture element for responsively switching between Images is considered as best practice

    <picture>
  <source media="(min-width: 650px)" srcset="img_food.jpg">
  <source media="(min-width: 465px)" srcset="img_car.jpg">
  <img src="img_girl.jpg">
</picture>

    more about picture element here📚

    Hope that helps, happy coding🔥🔥

    Marked as helpful
    0
    Harshit Joshi•120
    @TheFoxianPosted almost 2 years ago

    @sulemaan7070 thanks noted!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord